New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onAfterDestroy
callback description to react docs
#16281
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the mentioned things, please target the PR to the #stable
branch if we aim to deploy these changes without waiting until the next release.
@pomek It can be deployed in normal flow I think. There is no need to deploy it instantly after merge because this callback is not critical to work with integration (especially because it was not present for years). Thanks for suggestion to docs anyway. |
LGTM, you can merge it. As far as I understand, neither the new callback nor the docs for the callback are going to be released in this release (which should happen very shortly)? |
The required package has been released (https://github.com/ckeditor/ckeditor5-react/releases/tag/v7.0.0). |
We have ported these changes to new installation docs, which we plan on merging to |
Suggested merge commit message (convention)
Docs: Add
onAfterDestroy
callback description to React integration docs.Why has been this callback introduced?
onAfterDestroy
is being batched, so in other words rapidid
change (10 in row) will trigger only ~1 call of this callback which prevents race conditions inStrict Mode
.Additional information
onAfterDestroy
callback has been added in this commit in our React integration.