Update docker image to fix aws-cli, update doctor to properly report AWS info from within docker. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-cli expects glibc shared objects which are not present on alpine. Alternatives considered: 1. Adding gcompat to the apk add list. The aws-cli still linked against missing shared objects. 1. Add missing shared objects manually like in aws/aws-cli#4685 (comment). This approached seems very brittle so I opted to use non-alpine images instead.
nbeloglazov
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker image changes
The aws cli executable dynamically links against shared objects that are not included in alpine linux (build with musl instead of glibc). Update the docker image to build from non-alpine varients.
Alternatives considered:
missing shared objects.
[v2] Distribute binaries for alpine / musl libc aws/aws-cli#4685 (comment).
This approached seems very brittle so I opted to use non-alpine
images instead.
Resolves civiform/civiform#3508 (comment).
Doctor changes
aws helprequires groff, switch the command toaws --version.aws configure list-profilesdoes not work when only setting the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY env variables. Update check to callaws sts get-caller-identityinstead.Addresses some aspects of civiform/civiform#3544.