Backport GHA Migration to release-9.4 #7318
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hanefi Onaldi <Hanefi.Onaldi@microsoft.com> (cherry picked from commit e0b0cdb)
Since GHA does not interpolate env variables in a matrix context, This PR defines them in a separate job and uses them in other jobs. (cherry picked from commit 2bf1472)
Making tasks in CI required before merging to master is important and useful. The way this works is by saving the exact names of the required tasks in the admin interface of the repo. It has a search box to add them so it's not completely horrible, but doing so is quite a hassle since we have so many jobs. So limiting the amount of churn in this list of required jobs is quite useful. This changes the names of tasks to only include the major versions of Postgres, not the minor ones. Otherwise the next time we bump the minor versions we would have to remove and re-add each of the jobs. (cherry picked from commit 83e3fb8)
We are switching to Github Actions. In the test period it has worked well enough, so now we can stop using CircleCI. (cherry picked from commit ce58c04)
(cherry picked from commit 344bc5b)
(cherry picked from commit ec531c4)
(cherry picked from commit d69fe36)
(cherry picked from commit 512d185)
(cherry picked from commit 5d7924e)
(cherry picked from commit 3eb4f47)
(cherry picked from commit 9e0fee9)
Codecov Report
@@ Coverage Diff @@
## release-9.4 #7318 +/- ##
===============================================
- Coverage 91.48% 87.56% -3.93%
===============================================
Files 188 188
Lines 37707 37758 +51
Branches 0 4917 +4917
===============================================
- Hits 34497 33062 -1435
- Misses 3210 3232 +22
- Partials 0 1464 +1464 |
gokhangulbiz
force-pushed
the
release-9.4-gha
branch
2 times, most recently
from
997cfe6
to
7056e22
Compare
gokhangulbiz
force-pushed
the
release-9.4-gha
branch
from
7056e22
to
404ca61
Compare
| chown -R circleci . | ||
| git config --global --add safe.directory ${GITHUB_WORKSPACE} | ||
| PG_CONFIG=/usr/lib/postgresql/${{ inputs.pg_major }} >>/bin/pg_config | ||
| gosu circleci ./configure --without-pg-version-check |
There was a problem hiding this comment.
looks like --without-pg-version-check is unrecognized from CI outputs.
| matrix: | ||
| include: | ||
| - old_pg_major: 11 | ||
| new_pg_major: 12 |
There was a problem hiding this comment.
CI complains about Citus version is not supported for Postgres 13. It seems to me like we have PG_MAJOR=13 at image and we could not override that from CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: PR description that will go into the change log, up to 78 characters