Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripting/lua): redm oal natives #2481

Merged
merged 1 commit into from
May 28, 2024

Conversation

Ehbw
Copy link
Contributor

@Ehbw Ehbw commented Apr 23, 2024

Goal of this PR

Introduces faster OAL natives for RedM when using use_experimental_fxv2_oal true on the Lua 5.4 ScRT

How is this PR achieving the goal

By including the NativesRDR.h header file that is compiled and copied into citizen-scripting-lua/src.

This PR applies to the following area(s)

RedM, ScRT: Lua

Successfully tested on

Game builds: 1491.18

Platforms: Windows

Tested with scripts utilising Lua 5.3, MonoV1, JS and Lua 5.4 (without OAL) ScRT's. With all behaving as intended

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@github-actions github-actions bot added RedM Issues/PRs related to RedM ScRT: Lua Issues/PRs related to the Lua scripting runtime labels Apr 23, 2024
@Disquse Disquse self-assigned this Apr 23, 2024
@github-actions github-actions bot added the triage Needs a preliminary assessment to determine the urgency and required action label Apr 23, 2024
@Disquse
Copy link
Contributor

Disquse commented May 27, 2024

Tested a bit, seems to be working as intended. Those are disabled by default anyway, so it's good to go. Please report if there would be any issues.

@Disquse Disquse added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action labels May 27, 2024
@prikolium-cfx prikolium-cfx merged commit 2c286dc into citizenfx:master May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging RedM Issues/PRs related to RedM ScRT: Lua Issues/PRs related to the Lua scripting runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants