fix(scripting/lua): Fix not closing to-be-closed variables on error

[kajkul]

Goal of this PR

Call __close metamethod on to-be-closed variables (added in Lua 5.4) when an uncaught error occurs. Before this change variables would be closed only if the function/event/script execution ended without an error.

How is this PR achieving the goal

This PR calls the lua_resetthread method, when handling an error case, which unwinds the stack and closes all to-be-closed variables present there.

This PR applies to the following area(s)

ScRT: Lua

Successfully tested on

Platforms: Windows

Checklist

• Code compiles and has been tested successfully.
• Code explains itself well and/or is documented.
• My commit message explains what the changes do and what they are for.
• No extra compilation warnings are added by these changes.

[kajkul]

Don't know why the checks failed. It doesn't look like anything related to with this PR.

[gottfriedleibniz]

Actually. Would it be possible to call lua_resetthread prior to invoking FORMAT_STACK_TRACE? That execution path is not exception-free. ... In fact, it would probably be best if we wrapped that FxNativeInvoke::Invoke invocation in a try/catch

LGTM.

[gottfriedleibniz]

Amended previous message, just a few concerns that should probably be addressed.

[kajkul]

Actually. Would it be possible to call lua_resetthread prior to invoking FORMAT_STACK_TRACE?

I guess it might get the wrong stack trace if an error occurs during closing a variable.

That execution path is not exception-free. ... In fact, it would probably be best if we wrapped that FxNativeInvoke::Invoke invocation in a try/catch

Just did that.