tweak(natives-decl): add SET_VEHICLE_CURRENT_GEAR and NEXT_GEAR declarations

[RickyB505]

Goal of this PR

This will allow developers to create manual transmissions more easily with in FiveM.

How is this PR achieving the goal

Adds two natives SetVehicleCurrentGear(vehicle, gear) and SetVehicleNextGear(vehicle, nextGear) that exist with in VehicleExtraNatives.cpp but were never added.

This PR applies to the following area(s)

FiveM, Vehicles

Successfully tested on

Should work on any build.

Checklist

• Code compiles and has been tested successfully.
• Code explains itself well and/or is documented.
• My commit message explains what the changes do and what they are for.
• No extra compilation warnings are added by these changes.

[thorium-cfx]

Can you change the commit title to something like: tweak(natives-decl): add SET_VEHICLE_CURRENT_GEAR and NEXT_GEAR declarations? For the rest I've assigned @4mmonium, he's good at checking these

[RickyB505]

Can you change the commit title to something like: tweak(natives-decl): add SET_VEHICLE_CURRENT_GEAR and NEXT_GEAR declarations? For the rest I've assigned @4mmonium, he's good at checking these
fixed

[gottfriedleibniz]

I'll handle this, as it partially relates to: #2003 (comment)

[RickyB505]

i dont think it relates to that this is a separate thing

[gottfriedleibniz]

Much of CTransmission changed in 3095 and it is likely required to sanitize those setters against 0x61F02E4E9A7A61EA (nInitialDriveGears in CHandling iirc). It would be nice to ensure that is validated/handled prior to native declarations being provided.

[RickyB505]

well i can tell you they do work , because i tested them

[4mmonium]

Can you change the commit title to something like: tweak(natives-decl): add SET_VEHICLE_CURRENT_GEAR and NEXT_GEAR declarations? For the rest I've assigned @4mmonium, he's good at checking these

Doc implementation seems fine, now for underlying implementation @gottfriedleibniz might know better than I do; so as they stated, they should handle the rest 🙂

well i can tell you they do work , because i tested them

That's great, but structure changes between builds can cause memory related issues nonetheless (such as invalid data, crashes from invalid pointer access, etc), offsets that were valid in the past, might no longer be. So it's important to check the underlying implementation to make sure these things don't happen.

[RickyB505]

any updates on this has anyone checked the natives