Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earlier connect to server when using "fivem://connect" #2394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slashkeyvalue
Copy link
Contributor

Goal of this PR

When using ""fivem://connect"", the time between launching the game and getting any "connecting" feedback can about a minute on slower machines, so this PR aims to make use of a very cheap speed up to try and improve user feedback as it seems that the game can run initfunctions while connecting to a server instead of having to wait before connecting.

How is this PR achieving the goal

The game launcher now attempts a ConnectTo when netLibrary is created instead of waiting on INIT_CORE

This PR applies to the following area(s)

FiveM, RedM

Successfully tested on

Game builds: ..

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@github-actions github-actions bot added RedM Issues/PRs related to RedM triage Needs a preliminary assessment to determine the urgency and required action labels Feb 16, 2024
@gottfriedleibniz
Copy link
Contributor

I am not sure this is the correct approach to take at the moment.

In releng we have reports of slow game startup times due to other factors which your users may be experiencing the brunt of. It would be nice to address those problems prior to considering having this instance of "ConnectTo" be moved to so early in the initialization/hooking stage (which is likely to only be a temporary solution).

@slashkeyvalue
Copy link
Contributor Author

Unfortunately i don't have access to releng, so i just assumed that initfunction stuff was supposed to be a little slow ( as it'd be loading game stuff and whatnot ). But yeah, if there's some deeper problems related to loading times it'd be wise to focus on that.

That being said, even if though it's a temporary solution, i still think users could benefit of the increased connecting-to-server feedback while research/planning on actually improving startup times is done

@gottfriedleibniz gottfriedleibniz added status:deferred Action on this has been deferred to a later time and removed triage Needs a preliminary assessment to determine the urgency and required action RedM Issues/PRs related to RedM labels Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:deferred Action on this has been deferred to a later time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants