Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update philosophia-scientiae.csl #6802

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AntoineCDussault
Copy link

The style that was available for this journal was not doing at all what the guidelines for authors required. I thus created one not from the existing style but from the most closely similar I found.

Copy link

github-actions bot commented Dec 3, 2023

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

github-actions bot commented Dec 3, 2023

😟 There are some issues with your submission.

2 tests failed

philosophia-scientiae: must not use sentence case for title and container-title variables

expected "container-title" not to match /^title|container-title$/
Diff:
@@ -1 +1 @@
-/^title|container-title$/
+"container-title"

philosophia-scientiae: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/philosophia-scientiae"
     got: "http://www.zotero.org/styles/philosophia-scienciae"

(compared using ==)

Please check the test report for details.

@AntoineCDussault
Copy link
Author

I'm remaining unable to understand there errors:

philosophia-scientiae: must not use sentence case for title and container-title variables

expected "container-title" not to match /^title|container-title$/
Diff:
@@ -1 +1 @@
-/^title|container-title$/
+"container-title"

philosophia-scientiae: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/philosophia-scientiae"
got: "http://www.zotero.org/styles/philosophia-scienciae"

(compared using ==)

@adam3smith
Copy link
Member

  1. You should not set text-case="sentence" on titles -- it'll incorrectly lowercase proper nouns. CSL expects titles in sentence case, so for sentence case you shoudl just leave the text-case attribute out
  2. The journal name is Philosophia Scientiæ with a t, which is what the filename still is. You are using scienciae (with a c) in the ID and self link (and title)

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 10, 2023
I think I managed to make the changes I was requested to make.
Copy link

github-actions bot commented Jan 9, 2024

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

philosophia-scientiae.csl (rendering failure)

Copy link

😟 There are some issues with your submission.

1 test failed

philosophia-scientiae.csl
title should include natural language version of default-locale "en" in parentheses

Please check the test report for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants