Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winlogbeat.yml clarification on SSL/TLS usage. #286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

novaksam
Copy link

@novaksam novaksam commented May 7, 2024

πŸ—£ Description

Assisting someone with their setup and this was a minor point of confusion. Editing for better clarification.

πŸ’­ Motivation and context

Those unfamiliar with elastic beat products may be confused by the original comment lines take out of context from the base winlogbeat configuration file.

πŸ“· Screenshots (DELETE IF UNAPPLICABLE)

πŸ§ͺ Testing

No testing needed, changes exist only in comments.

βœ… Pre-approval checklist

  • Changes are limited to a single goal AND
    the title reflects this in a clear human readable format
  • Issue that this PR solves has been selected in the Development section
  • I have read and agree to LME's CONTRIBUTING.md document.
  • The PR adheres to LME's requirements in RELEASES.md
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.

βœ… Pre-merge Checklist

  • All tests pass
  • PR has been tested and the documentation for testing is above
  • Squash and merge all commits into one PR level commit

βœ… Post-merge Checklist

  • Delete the branch to keep down number of branches

Assisting someone with their setup and this was a minor point of confusion. Editing for better clarification.
@novaksam novaksam changed the title Clarification on SSL/TLS usage. Winlogbeat.yml clarification on SSL/TLS usage. May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: πŸ†• Product Backlog
Development

Successfully merging this pull request may close these issues.

None yet

1 participant