Break up selenium tests #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rishagg01
approved these changes
May 8, 2024
| driver = setup_login | ||
| dashboard_test_function(driver, kibana_url, timeout, self.dashboard_id, "AV Hits (Count)", ".visualization",".dummyval") | ||
|
|
||
|
|
There was a problem hiding this comment.
Remove extra lines at end of file
mitchelbaker-cisa
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
💭 Motivation and context
The selenium tests needed to be broken up so they could individually fail and also be split between cluster and linux only runs.
🧪 Testing
The tests are designed to run locally and in the pipeline
✅ Pre-approval checklist
the title reflects this in a clear human readable format
✅ Pre-merge Checklist
✅ Post-merge Checklist
#265