Add support for AS table_alias syntax for inserts in Postgres
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could use some more tests and possibly some refactoring, but this should do it. |
coderdan
reviewed
Nov 25, 2023
| @@ -7105,6 +7105,15 @@ impl<'a> Parser<'a> { | |||
| // Hive lets you put table here regardless | |||
| let table = self.parse_keyword(Keyword::TABLE); | |||
| let table_name = self.parse_object_name()?; | |||
|
|
|||
| let is_postgresql = dialect_of!(self is PostgreSqlDialect); | |||
There was a problem hiding this comment.
According to the docs, dialect specific syntax needs to be handled for both the dialect in question and the GenericDialect.
There was a problem hiding this comment.
I think that only applies when you need to make changes to the dialect itself. I don't think that matters here, but I'll see what the maintainer says when I raise it upstream.
I still need to check other dialects as well to verify that this needs to be dialect specific.
There was a problem hiding this comment.
Isn't this doing exactly that? Changing the dialect?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using table aliases in inserts.