Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added paste image support #167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tobias-kuendig
Copy link

@tobias-kuendig tobias-kuendig commented May 13, 2023

Description

This PR introduces support to paste images. It utilizes the arboard crate to fetch image data from the clipboard, then provides it as a base64 encoded string to the frontend using a Tauri command.

This PR depends on cinnyapp/cinny#1238

Fixes #69

Tested on Ubuntu 22.04 LTS on Wayland.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions
Copy link

github-actions bot commented May 13, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@tobias-kuendig
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@ghost
Copy link

ghost commented Sep 6, 2023

When will it be merged? Are there any blockers?

hugeblank added a commit to hugeblank/cinny-desktop that referenced this pull request Sep 26, 2023
Does what title says.

Lifts event handler logic from paste image support (cinnyapp#167).

Includes some commented out logic for compatibility with systray (cinnyapp#166) when/if merged. Requires TRAY_LABEL be exposed as public, however.
hugeblank added a commit to hugeblank/cinny-desktop that referenced this pull request Sep 26, 2023
Does what title says.

Lifts event handler logic from paste image support (cinnyapp#167).

Includes some commented out logic for compatibility with systray (cinnyapp#166) when/if merged. Requires TRAY_LABEL be exposed as public, however.
@b1ek
Copy link

b1ek commented Jan 29, 2024

When will it be merged? Are there any blockers?

+1 on this. @kfiven @ajbura can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image paste not working from clipboard
2 participants