Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix cosign instructions #2232

Merged
merged 1 commit into from Mar 17, 2024
Merged

Conversation

lambdanis
Copy link
Contributor

Cosign documentation was migrated to https://docs.sigstore.dev/ in sigstore/cosign#822 and the markdown files were removed in sigstore/cosign#3587. Tetragon documentation was linking to one of this files. Now it's linking to https://docs.sigstore.dev/.

While here, remove COSIGN_EXPERIMENTAL=1 from the cosign command for verifying keyless-signed images. It's not required since cosign v2.0.0 (see https://blog.sigstore.dev/cosign-2-0-released/).

Fixes #2209

Cosign documentation was migrated to https://docs.sigstore.dev/ in
sigstore/cosign#822 and the markdown files were removed in sigstore/cosign#3587.
Tetragon documentation was linking to one of this files. Now it's linking to
https://docs.sigstore.dev/.

While here, remove `COSIGN_EXPERIMENTAL=1` from the cosign command for
verifying keyless-signed images. It's not required since cosign v2.0.0
(see https://blog.sigstore.dev/cosign-2-0-released/).

Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
@lambdanis lambdanis added release-note/misc This PR makes changes that have no direct user impact. release-note/docs This PR updates the documentation. labels Mar 17, 2024
@lambdanis lambdanis requested review from mtardy and a team as code owners March 17, 2024 15:23
Copy link

netlify bot commented Mar 17, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit b59cfbb
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/65f70ae5046ca700082e1207
😎 Deploy Preview https://deploy-preview-2232--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lambdanis lambdanis removed the release-note/misc This PR makes changes that have no direct user impact. label Mar 17, 2024
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to look into this!

@mtardy mtardy merged commit 899b46d into cilium:main Mar 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/docs This PR updates the documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: broken links automatic report
2 participants