Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove gobpf, mention cilium/ebpf #18657

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

ti-mo
Copy link
Contributor

@ti-mo ti-mo commented Jan 28, 2022

As it's been unmaintained for a while, and there are talks of officially deprecating gobpf, I guess it's time to remove it here.

I was hinted by a fellow community member that this list might need a bit of work (or we could just redirect to ebpf.io instead), but cilium/ebpf should at least be mentioned here for now.

@ti-mo ti-mo added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Jan 28, 2022
@ti-mo ti-mo requested a review from a team January 28, 2022 21:38
@ti-mo ti-mo requested a review from a team as a code owner January 28, 2022 21:38
@ti-mo ti-mo requested review from kkourt and qmonnet January 28, 2022 21:38
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With proper RST formatting you should be able to get rid of the changes on the spelling file.

One comment on bpf_link, but the rest of the text looks all good.

Documentation/bpf.rst Outdated Show resolved Hide resolved
Documentation/bpf.rst Outdated Show resolved Hide resolved
Documentation/bpf.rst Outdated Show resolved Hide resolved
Documentation/bpf.rst Outdated Show resolved Hide resolved
As it's been unmaintained for a while, and there are talks [0] of officially
deprecating gobpf, I guess it's time to remove it here.

I was hinted by a fellow community member that this list might need a bit of
work (or we could just redirect to ebpf.io instead), but cilium/ebpf should
at least be mentioned here for now.

[0]: iovisor/gobpf#304

Signed-off-by: Timo Beckers <timo@isovalent.com>
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 31, 2022
@glibsm glibsm removed the request for review from kkourt January 31, 2022 17:53
@glibsm glibsm merged commit 56c259b into cilium:master Jan 31, 2022
@ti-mo ti-mo deleted the tb/deprecate-gobpf branch January 31, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants