Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CLI functionality #303

Merged
merged 1 commit into from
May 23, 2024
Merged

Remove CLI functionality #303

merged 1 commit into from
May 23, 2024

Conversation

totakke
Copy link
Member

@totakke totakke commented Mar 21, 2024

I removed CLI functionality from cljam and added a notice message about Gnife to README.md.

This PR aims at separating the CLI functionality from cljam and making cljam a pure Clojure library.
Gnife is a pure CLI and contains all cljam's commands in sequence and sam types. (See https://github.com/chrovis/gnife/blob/main/README.md#command-list)

I confirmed lein test :all passed.
I will leave the merge timing of this PR up to you.

@totakke totakke requested review from alumi and a team as code owners March 21, 2024 13:17
@totakke totakke requested review from athos and removed request for a team March 21, 2024 13:17
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.64%. Comparing base (ec9c199) to head (ac0d716).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
+ Coverage   88.25%   88.64%   +0.39%     
==========================================
  Files          85       83       -2     
  Lines        7381     7143     -238     
  Branches      488      447      -41     
==========================================
- Hits         6514     6332     -182     
+ Misses        379      364      -15     
+ Partials      488      447      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alumi alumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
As we have many commits since 0.8.4, my plan is to merge PRs for CRAM (#302 and some improvements) first and release 0.8.5. Following that, I aim to merge this PR into 0.9.0-SNAPSHOT.
The changes look good 👍 I'll keep this PR open until the next release.

Copy link
Member

@athos athos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change itself looks good 🙆

Copy link
Member

@alumi alumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased this branch onto the latest master.
This will be included in the next release 0.9.0.

@alumi alumi merged commit 8cecbb2 into master May 23, 2024
16 checks passed
@alumi alumi deleted the fix/remove-cli branch May 23, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants