Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing C functions since 3.11 and 3.12 #27

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

@chrispahm
Copy link
Owner Author

@sanak would appreciate if you could have a look and check if I got it right!

@sanak
Copy link
Contributor

sanak commented Apr 29, 2024

@chrispahm

@sanak would appreciate if you could have a look and check if I got it right!

Sorry, I missed this PR for a quite long time... 🙇
I will check this in this week.

@sanak
Copy link
Contributor

sanak commented May 12, 2024

Well, there will be Japan frontend geo online tech meetup at 2024-05-18(Sat), so I will do this at that time...
https://osgeojp.connpass.com/event/317706/

@sanak
Copy link
Contributor

sanak commented May 18, 2024

@chrispahm Thanks for a lot of work!
I added some comments in the following Check column (needs scroll), so please checking these. 🙇
(The last GEOSSTRtree_build, GEOS parameter comment is missing, so I will create an issue for GEOS side, later.
=> I created the issue (libgeos/geos#1096))

Function name GEOS CAPI definition
(capi/geos_c.h.in)
GEOS-WASM definition
(src/allCFunctions.mjs)
GEOS-WASM doc
(docs/functions/geos.*.md)
Check
GEOSGeom_createRectangle #L2486-L2498 #L3316-L3342 GEOSGeom.md o
GEOSGeom_getExtent #L2780-L2798 #L3520-L3548 GEOSGeom.md x (no _r)
GEOSRemoveRepeatedPoints #L3107-L3126 #L1398-L1434 GEOSRemoveRepeatedPoints.md o
GEOSPolygonHullSimplify #L4010-L4032 #L2483-L2523 GEOSPolygonHullSimplify.md o
GEOSPolygonHullSimplifyMode #L4045-L4070 #L2524-L2568 GEOSPolygonHullSimplify.md o
GEOSLineMergeDirected #L4442-L4453 #L2639-L2665 GEOSLineMerge.md o
GEOSHilbertCode #L4534-L4554 #L4693-L4726 GEOSHilbertCode.md x (none _r has handle)
GEOSGeom_transformXY #L4556-L4573 #L4727-L4757 GEOSGeom.md o
GEOSWKTReader_setFixStructure #L5368-L5378 #L3651-L3669 GEOSWKTReader.md o
GEOSWKBReader_setFixStructure #L5495-L5505 #L3856-L3874 GEOSWKBReader.md o
GEOSGeomGetM #L2654-L2663 #L2163-L2183 GEOSGeom.md o
GEOSHasM #L2860-L2867 #L2799-L2814 GEOSHasM.md o
GEOSDisjointSubsetUnion #L3551-L3561 #L1651-L1673 GEOSDisjoint.md o
GEOSCoverageIsValid #L3795-L3821 #L1693-L1741 GEOSCoverageIsValid.md o
GEOSCoverageSimplifyVW #L3836-L3851 #L1742-L1794 GEOSCoverageSimplifyVW.md o
GEOSLineSubstring #L4455-L4469 #L2666-L2690 GEOSLineSubstring.md o
GEOSEqualsIdentical #L4773-L4787 #L493-L519 GEOSEquals.md o
GEOSPreparedContainsXY #L4906-L4920 #L4141-L4165 GEOSPrepare.md o
GEOSPreparedIntersectsXY #L5006-L5020 #L4280-L4304 GEOSPrepare.md o
GEOSSTRtree_build #L5140-L5151 #L4419-L4443 GEOSSTRtree.md x (number arg for tree is missing in Module.cwrap last arg)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing C functions since 3.11 and 3.12
2 participants