Fix Default Selector for Code Themes #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for astro-theme-cactus pending review.Visit the deploys page to approve it
|
nhtsai
changed the title
|
Hey @nhtsai, I'm not sure if you're having issues with this but in testing I don't see what this changes/fixes. The theme closely follows Starlight's config which the maintainer of expressive-code created, and also the default for expressive-code, so I'm not sure what's wrong? |
|
Hey @chrismwilliams, I was trying to keep one code theme for both light and dark modes, but it looks like it was an issue on my end. I'm completely new to web dev, so I appreciate you providing some context to learn more, thanks! Closing this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
Fixes a typo in the default theme selector for code syntax highlighting.