Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template string not valid in VALIDATOR_TYPE_REGEX #232

Merged
merged 1 commit into from May 23, 2024
Merged

Fix template string not valid in VALIDATOR_TYPE_REGEX #232

merged 1 commit into from May 23, 2024

Conversation

lambertkevin
Copy link
Contributor

@lambertkevin lambertkevin commented Jan 3, 2024 •
edited

Add the ` character in the VALIDATOR_TYPE_REGEX in order to support template strings with custom validator.

Fixes #231

@lambertkevin lambertkevin force-pushed the bugfix/fix-template-string-in-custom-validator branch from 0ef4f28 to 2141c5d Compare January 3, 2024 20:42
chrishoermann
chrishoermann approved these changes May 23, 2024
View reviewed changes
Copy link
Owner

@chrishoermann chrishoermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the test. Took me some time but I'll try to get a release with the fix out as soon as possible.

@chrishoermann chrishoermann merged commit 768f8cb into chrishoermann:master May 23, 2024
@lambertkevin lambertkevin deleted the bugfix/fix-template-string-in-custom-validator branch May 23, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishoermann chrishoermann chrishoermann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Can't use z.literal with template string
2 participants
@lambertkevin @chrishoermann