Implement proper handling of the _NET_CM_Sn selection #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before becoming the selection owner for _NET_WM_CM_Sn, compton will now check if that selection is already owned (which means that another composite manager is already running). If this check fails, startup will be refused. This behaviour is required by EWMH / ICCCM. Because this should catch all composite managers, the error message that was used before when another manager is already running is reworded to mention that the other manager does not follow EWMH. Signed-off-by: Uli Schlachter <psychon@znc.in>
Again, this behaviour is required by ICCCM. Signed-off-by: Uli Schlachter <psychon@znc.in>
tryone144
pushed a commit
to tryone144/compton
that referenced
this pull request
Mar 25, 2020
While /dev/null is always empty, it still generates inotify events. So using /dev/null as config file will cause the compositor to reset itself frequently. Not entire sure if only allowing regular files is sufficient, but we will be doing this until an issue comes up. Fixes chjj#320 Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes/implements mostly the required behavior for #301. Startup is refused if
_NET_CM_Snis already owned and when that selection is lost, compton exits.If someone wants, they could add a
--replaceflag ontop of this, but I am too lazy for that. For this it should only be needed to skip the exit and wait for the old selection owner window to be destroyed before continuing startup.