Build system fixes #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xiretza <xiretza@xiretza.xyz>
Signed-off-by: Xiretza <xiretza@xiretza.xyz>
This fixes builds with `setup.py develop`/`pip install -e`. build_ext.run() unsets build_ext.inplace before running build_extension(), and only restores it before calling copy_extensions_to_source(). Because the cmake extension has to know the real install directory in build_extension(), we need to compute it before calling build_ext.run() and then retrieve it in build_extension(). Signed-off-by: Xiretza <xiretza@xiretza.xyz>
super().run() already builds all the extensions Signed-off-by: Xiretza <xiretza@xiretza.xyz>
Signed-off-by: Xiretza <xiretza@xiretza.xyz>
With external (distro) gtest, this avoids an error along the lines of "DSO missing from command line". Signed-off-by: Xiretza <xiretza@xiretza.xyz>
Xiretza
force-pushed
the
cmake-install-fixes
branch
from
04d3a26
to
9ebb730
Compare
|
I believe I have tamed the setuptools monster. I have to say this whole "embedding cmake in setup.py" approach is quite cursed. |
|
Ah, I'm packaging this in nixpkgs and was slowly re-inventing the work you had done here. I'll just point at your branch since this hasn't received any feedback... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While packaging fasm for the AUR, I came across a bunch of problems that I hope I'll be able to fix upstream here so others can benefit from the fixes too. These changes shouldn't change anything about the "intended" build workflow, but allow distro packages to build the package according to packaging standards.