Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for #[derive(Debug, serde::Serialize, serde::Deserialize)] to SharedStruct #248

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wooden-worm
Copy link

Expanding on #198

Let me know if this is heading toward the right direction, I can add more tests later.

@chinedufn
Copy link
Owner

Looks like the right direction

@wooden-worm
Copy link
Author

I added a few tests, let me know if I missed anything.

@jmp-0x7C0
Copy link

@wooden-worm are you still working on this PR? I could really use this feature, and I'd be happy to help move this forward.

@wooden-worm
Copy link
Author

I've added a few tests, not sure what else this needs in order to merge?

@jmp-0x7C0
Copy link

@wooden-worm thanks for the quick reply.

@chinedufn are there any other required changes before this can be merged?

@chinedufn
Copy link
Owner

I'll take a look over the weekend.

@extrawurst
Copy link

I am in dire need to be able to have #[derive(Debug, Default, Clone)] on shared structs. also I am wondering how to make them vectorizable aka allow me to return a Vec<T> of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants