frontend/udp: ensure race-free shutdown #618
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #608
New mechanism to shut down cleanly:
closing
is closed, only once, guarded by the mutex.serve
eventually restarts its loop and realizes we're closing.serve
closesserveShutdown
when it returns.serveShutdown
signalsStop
thatserve
has returned and no more calls tof.wg.Add
can be made.5. f.wg.Wait
is called, which should be race-free now.Hope that make sense.
Also, some cleanup with where
f.wg.Add
is called.Also, this should hopefully finally fix the flaky CI and allow us to merge a bunch of PRs, maybe.