-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: add redis-socket scheme for connect to redis with unix socket #598
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
I've added one comment. Also, there's documentation, could you add a note about the addresses in there, too, please? And maybe in the example config as well.
Don't worry about CI failing. We'll fix it at some point and merge then.
Thank you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Again, the CI is broken, we'll fix it at some point. Because of that I won't merge it now, just leave it open, we'll come back to it :)
Hello! The CI is fixed :) If you rebase this PR, we can probably merge it. Thanks again! |
Sorry, I missed this earlier: Can you squash your two commits into one and give it a name of this schema:
As described here in more detail. Sorry for missing that last time! The changes look good. |
is something wrong again? |
Oh, sorry, this fell under the table. Changes look good, as before :) We have a data race which will probably block CI, again... really sorry. Anyway, just leave this open, we'll fix it eventually and merge. Thank you! |
Ref: #595
address of redis storage now can be specified as :