planned solar projects #45

derekeder · 2024-05-08T17:04:20Z

closes add solar projects in the queue #42
partially implements save state to url in map: position, zoom and layers selected #31

Tasks to implement:

identify source files for planned projects from EIA, ABP and ILSFA
add source files to project and extract to csv files
combine planned projects into one file
update aggregates to include planned projects for dg_small, dg_large, cs and utility
add planned numbers to geojson and csv files
update map to toggle between energized and planned
update tables to show energized and planned
update about page text to include planned project info and counts

Testing instructions

browse the map and confirm you can toggle between energized and planned projects (planned should show up in purple). hovering over a geography should show a table with energized and planned projects
confirm that the buttons selected are updated in the URL as you click them. copying a URL with options selected and pasting into a new tab/window should load the map with those options selected
confirm on the about page that there is a new section on planned solar projects
view the reference tables page and confirm they all include a set of columns for planned projects

netlify · 2024-05-15T21:20:07Z

✅ Deploy Preview for il-solar-map ready!

Name	Link
🔨 Latest commit	`b33e061`
🔍 Latest deploy log	https://app.netlify.com/sites/il-solar-map/deploys/664e6c9a46e557000986a64d
😎 Deploy Preview	https://deploy-preview-45--il-solar-map.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vkoves · 2024-05-17T19:59:57Z

@derekeder - not related to this, but I wanted to mention the active state of each toggle definitely looks like it would fail a contrast check. I also wonder if it's worth putting an explainer somewhere of what/how you get "planned" projects. Like what's the certainty those would happen and how far out might they be?

derekeder · 2024-05-17T20:03:35Z

@vkoves good catch! i'll open a separate PR for the contrasting buttons and pick it up in another PR. would you believe its a bootstrap default!?

Agreed on the language too. I will ping the clean jobs folks and see what the say. That makes sense to address in this PR

vkoves

I have some starting comments, but I think I'll need a good bit more documentation to understand what your doing where, since I'm just jumping into this for the first time. From testing it seems fine though!

about.html

data/scripts/aggregate_data.py

vkoves · 2024-05-17T20:02:57Z

data/scripts/combine_projects.py

+            cur_project["kw"] = clean_number(row["Project Size AC kW"])
+            cur_project["census_tract"] = row["Census Tract Code"]
+            if project_type == "planned":
+                cur_project["energization_date"] = row["Scheduled Energization Date"]


I try to avoid magic strings, so I'd consider making a constant for the available columns in your data, as otherwise someone could slip in a typo on one specific check

can you say more here? this script is combining 3 different CSVs and aligning the appropriate columns into a shared form

What I mean is that hard coding energization_date and Scheduled Energ... is dangerous, since someone could be referencing those elsewhere, make a typo, and break something. Constants, like OrigCols.EnegDate prevent that, since the variable would bomb out if you have a typo.

ah, i understand. that's easier to do in javascript due to the way they interpret json data. it would take some code to turn each of these string values in the python dict to act as variables, so probably not worth it.

vkoves · 2024-05-17T20:03:47Z

index.html

+        <br /><br />
+        <h5>Select status</h5>
+        <div id="status-select" class="btn-group flex-wrap" role="group" aria-label="Status">
+          <button value="energized" type="button" class="btn btn-light active">Energized</button>


This is an issue with your other buttons as well, but worth noting a toggle button like this should use aria-pressed to indicate to screen readers when it's active or not. Accessibility might just be a separate task though

i will open this up as a separate issue to address

vkoves · 2024-05-17T20:06:01Z

reference-tables.html

@@ -12,6 +12,8 @@ <h1>Reference Tables</h1>
  <li><a href="#il-senate">IL State Senate Districts</a></li>
 </ul>

+<p>Note, all values are in kilowatts (kW). Columns with a <code>PL_</code> prefix are planned and not yet energized projects.</p>


Minor, but wanted to mention you can add thead { position: sticky; top: 0; } to this table to have the headers and filters stick, which makes it a lot easier to read and understand

The column titles are also a little technical, I don't know what CS means, and I think using titlecase and human words helps:

Lastly please add units! Otherwise it's unclear what each thing is referencing, and I thought it was the count of projects, not kW of capacity

adding kW to each value is a bit more involved if we want the sorting to work, so i'll open a separate issue

vkoves · 2024-05-17T20:10:22Z

js/map.js

        </tr>
      </thead>
      <tbody>
        <tr>
          <td>Total</td>
          <td><span class='float-end'>${props.total_kw.toLocaleString()}kW</span></td>
          <td><span class='float-end'>${props.total_count.toLocaleString()}</span></td>
+          <td><span class='float-end'>${props.planned_total_kw.toLocaleString()}kW</span></td>


A space before kw would make these all a lot readable in my opinion, e.g. 49,038kW vs 49,038 kW.

So it looks like you only did this on the total, I meant it for the whole table 😆

I'll leave that for later though

ah woops - i'll get that fixed

vkoves · 2024-05-17T20:10:42Z

js/map.js

        </tr>
      </tbody>
    </table>
  `
 }

-function updateLegend(layerSource, category){
-  let legendText = `<strong>${friendly_category_names[category]} kW of solar installed<br />by ${friendly_geography_names[layerSource]}</strong>`
+function updateLegend(layerSource, category, status){


Oh no, jQuery 😭

i'm using it for a few plugins I need:

jquery csv for converting a csv into a list of javascript objects

jquery address for updating and loading in query string parameters

One day, we can switch it to React or Vue 😆

js/map.js

derekeder · 2024-05-21T20:04:26Z

@vkoves thx for the review. I addressed or commented (and opened PRs) for your comments. we can discuss tonight at hack night

vkoves · 2024-05-22T02:05:50Z

@derekeder - I also noticed that you changed the scale, which means that there's more faint colors overall, is this okay?

Before	After

data/scripts/get_tract_districts.py

vkoves

Looks good to me! I'm not sure how best to validate the data other than to compare the data to prod, and it looks the same but fainter (see my comment about shifting the scale). I'd say anything else (adding space before kw on each row of the table, the map color scale) can be done in another PR!

derekeder · 2024-05-22T22:08:11Z

@vkoves thx! addressed the simple feedback. also made the buckets a little closer to what they were before. you're right - the map did look pretty light

derekeder added 3 commits May 8, 2024 11:40

shell command to extract planned data, cleanup script

9cca37e

combining planned projects

98e5e9e

added districts for planned files

0377299

derekeder marked this pull request as draft May 8, 2024 22:15

derekeder added 5 commits May 10, 2024 12:17

aggregating planned and energized data

90d5666

add planned vs energized toggle

8c7c892

using new colors for planned vs energized, showing all in hover

48c6c5e

update jenks breaks

c00c254

added planned projects to reference tables

43accbe

derekeder marked this pull request as ready for review May 10, 2024 22:07

derekeder added 4 commits May 13, 2024 19:02

saving geography, category and status to url param

3454fa0

fix for initial state

447143a

added planned info to about

e6b3d95

Trigger Build

a5053c4

derekeder requested review from vkoves and viennguyen2026 May 15, 2024 21:20

derekeder mentioned this pull request May 17, 2024

accessibility: toggle button contrast #47

Open

vkoves requested changes May 17, 2024

View reviewed changes

This was referenced May 21, 2024

accessibility: buttons should use aria-pressed #48

Open

add kW units to reference tables #49

Open

use friendlier column names for reference tables #50

Open

added comments and docstrings to scripts, feedback on readability

7538b8c

vkoves reviewed May 22, 2024

View reviewed changes

data/scripts/get_tract_districts.py Outdated Show resolved Hide resolved

vkoves approved these changes May 22, 2024

View reviewed changes

small text changes

6cf563c

moved total tract buckets

b33e061

derekeder merged commit 9c5914f into main May 22, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planned solar projects #45

planned solar projects #45

derekeder commented May 8, 2024 •

edited by viennguyen2026

netlify bot commented May 15, 2024 •

edited

vkoves commented May 17, 2024

derekeder commented May 17, 2024

vkoves left a comment

vkoves May 17, 2024

derekeder May 21, 2024

vkoves May 22, 2024

derekeder May 22, 2024

vkoves May 17, 2024

derekeder May 21, 2024

vkoves May 17, 2024

derekeder May 21, 2024 •

edited

vkoves May 17, 2024

derekeder May 21, 2024

vkoves May 22, 2024

derekeder May 22, 2024

vkoves May 17, 2024

derekeder May 21, 2024

vkoves May 22, 2024

derekeder commented May 21, 2024

vkoves commented May 22, 2024

vkoves left a comment

derekeder commented May 22, 2024

planned solar projects #45

planned solar projects #45

Conversation

derekeder commented May 8, 2024 • edited by viennguyen2026

Testing instructions

netlify bot commented May 15, 2024 • edited

✅ Deploy Preview for il-solar-map ready!

vkoves commented May 17, 2024

derekeder commented May 17, 2024

vkoves left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derekeder May 21, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derekeder commented May 21, 2024

vkoves commented May 22, 2024

vkoves left a comment

Choose a reason for hiding this comment

derekeder commented May 22, 2024

derekeder commented May 8, 2024 •

edited by viennguyen2026

netlify bot commented May 15, 2024 •

edited

derekeder May 21, 2024 •

edited