Webpack #346
Webpack #346
Conversation
|
Looks like you put a lot of work into this and I'm behind the idea! Question: is there a reason the built files are now minified? |
|
I'm not convinced moving to SCSS is a great idea. If this project was moved to anything, I'd personally prefer to see it moved to PostCSS. The CSS is so simple that I really don't see a need to migrate it to a pre/post processor. @chieffancypants thoughts? |
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "angular-loading-bar", | |||
| "version": "0.9.0", | |||
| "version": "0.10.0", | |||
There was a problem hiding this comment.
Please revert this version bump, if the PR is merged we'll bump the version as part of the release process (which will generate a git tag as well)
There was a problem hiding this comment.
already done. See commit 0722a8e
package.json
Outdated
| "karma-coverage": "^0.1.0", | ||
| "angular-animate": "^1.6.3", | ||
| "angular-mocks": "^1.6.3", | ||
| "css-loader": "^0.27.3", | ||
| "grunt": "~0.4.1", |
webpack.config.js
Outdated
| test: /\.js$/, | ||
| exclude: /node_modules/, | ||
| loaders: [ | ||
| 'ng-annotate-loader' |
There was a problem hiding this comment.
mixed ' and " in this file
There was a problem hiding this comment.
I will take care for this issue.
|
I added the minification, because the build files are the thing that is used when using bower + wiredep in script tags. Maybe it makes more sense to have the minified core proper source mapped (eg. for debugging). Reason to use SCSS is the automated vendor prefixing for rules. There were quite a lot of of vendor specific rules in the CSS. This hab bad impact on readability and is error prone. |
|
Code changes applied (see 7922c94) |
CSSAs someone who doesn't use SCSS anymore and ideally never will again, I'd rather see standard CSS or PostCSS used. Leave it to you and @chieffancypants to decide. MinificationI suppose you could output both a built vanilla and built minified version, people can choose. WebpackI use webpack too, importing like: |
Migration to Webpack and CommonJS compatibility
What issue is this PR resolving? Alternatively, please describe the bugfix/enhancement this PR aims to provide
Migrating build system of angular-loading-bar to Webpack. Furthermore making it usable as a CommonJS module from other Webpack projects or from node.js (via require()), while keeping compatibility to direct browser usage in <script> tags.
Have you provided unit tests that either prove the bugfix or cover the enhancement?
Unit tests are still working after migration. This PR does not contain functional code changes.
Related issues
#320