Added pagination to the admin users index page under settings #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim
pushed a commit
that referenced
this pull request
May 20, 2024
# What it does These changes allow admin users to filter the users index page in the admin interface by role. By default they'll see all users, but they can choose admin only, staff only, or members only. # Why it is important This should make some admin tasks easier when it comes to users. See #1251 for more. # UI Change Screenshot With the members only filter active: <img width="1102" alt="Screenshot 2024-05-15 at 9 46 00 PM" src="https://github.com/chicago-tool-library/circulate/assets/3209502/782275f2-4f99-413f-b750-19f8cef797eb"> With the admin only filter active: <img width="1096" alt="Screenshot 2024-05-15 at 9 45 41 PM" src="https://github.com/chicago-tool-library/circulate/assets/3209502/07985dce-424e-4603-861d-28ceea5d99f7"> With no filters active (ie all users): <img width="1161" alt="Screenshot 2024-05-15 at 9 45 29 PM" src="https://github.com/chicago-tool-library/circulate/assets/3209502/1bcec054-0188-4326-a123-e00fae7a99f9"> # Implementation notes The card didn't specifically mention being able to filter by the member role but I included it anyway. ~~Not sure if pagination or sorting would be helpful here as well.~~ I just went through the pagination card for this page (#1496).
jim
reviewed
May 20, 2024
crismali
force-pushed
the
add-pagination-to-admin-users-index-page
branch
from
d6c7146
to
75a8815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds pagination with pagy to the users index page under settings.
Why it is important
Currently this page takes just over 2 seconds to load so this should speed things up significantly. See #1249 for more.
UI Change Screenshot
Implementation notes
Just as basic a pagy implementation as I could manage. I also worked on #1495 which involves filtering this same page. Once one of these is merged it might take a little work on the other to make sure the filters and pagination don't cause any issues with one another, which I'm happy to take care of. Alternatively, these two could be combined? Depends on how useful one is without the other.