[MRG] adding the bounding box parsing code to the dashboard #83
Conversation
adding the bounding box parsing code to the dashboard
|
the others look ok |
notebooks/dashboard.ipynb
Outdated
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "def get_bbox_handles(in_view_dict):\n", |
There was a problem hiding this comment.
move this guy to jupyanno/cornerstone.py?
I'd also add the below as a helper in utils.py to make things easier to read:
def getIn(a_dict, *args):
value = a_dict[args[0]]
for arg in args[1:]:
value = value[arg]
return valueso that it raises an exception when the key doesn't exist.
There was a problem hiding this comment.
I think it probably makes more sense to have the code in cornerstone_widget chestrays/cornerstone_widget#8
There was a problem hiding this comment.
@betatim we actually do not want an exception because lots of images won't have any bounding boxes (healthy patients) or contain other information (like the plotly or standard image widget) and we don't want it to fail on those.
|
I'll take a look at the BBox dragging issue in cornerstone. |
|
Drag behaviour is fixed in chestrays/cornerstone_widget#17 |
|
Ready to merge |
kmader
changed the title
Seems to be an issue if you make a BBOX and then drag it, that it does not register the drag (maybe using mouseup events is not sufficient)