New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Adding bounding boxes and fixing notebooks #25
base: master
Are you sure you want to change the base?
Conversation
kmader
commented
Oct 1, 2018
•
edited
edited
- fixing notebook zoom code
- adding code to manipulate bounding boxes in cornerstone
- works on easy functions for ROIs #8
fixing notebook zoom
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=========================================
+ Coverage 63.28% 64.88% +1.6%
=========================================
Files 4 4
Lines 463 487 +24
=========================================
+ Hits 293 316 +23
- Misses 170 171 +1
Continue to review full report at Codecov.
|
@betatim I've added the basic functionality, but the bounding boxes do not show up for some reason. The demo.ipynb is probably the best starting point for experimenting |
…s a box (still does not work correctly), adding a block to the demo notebook to make adding rois interactively easier)
@betatim now the bounding boxes show up, but it is still a bit finicky |
"""A method for feeding data into the widget""" | ||
self._tool_state_in = json.dumps(state) | ||
self._tool_state_out = json.dumps(state) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why the two tool states?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this isn't a very elegant approach, but one is for setting the state (_in) from Python and one is for reading the state (_out) from Cornerstone. The state itself isn't a traitlet and the traitlet is only updated on a mouseup event