Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding bounding boxes and fixing notebooks #25

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kmader
Copy link
Collaborator

@kmader kmader commented Oct 1, 2018

fixing notebook zoom
@kmader kmader changed the title Updating notebooks Adding bounding boxes and fixing notebooks Oct 1, 2018
@codecov-io
Copy link

codecov-io commented Oct 1, 2018

Codecov Report

Merging #25 into master will increase coverage by 1.6%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #25     +/-   ##
=========================================
+ Coverage   63.28%   64.88%   +1.6%     
=========================================
  Files           4        4             
  Lines         463      487     +24     
=========================================
+ Hits          293      316     +23     
- Misses        170      171      +1
Impacted Files Coverage Δ
cornerstone_widget/utils.py 96.77% <100%> (+0.69%) ⬆️
cornerstone_widget/cs_widget.py 90.07% <86.66%> (+0.22%) ⬆️
cornerstone_widget/_version.py 44.4% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85e878a...b100da6. Read the comment docs.

@kmader kmader changed the title Adding bounding boxes and fixing notebooks [WIP] Adding bounding boxes and fixing notebooks Oct 1, 2018
@kmader kmader requested a review from betatim October 1, 2018 21:45
@kmader
Copy link
Collaborator Author

kmader commented Oct 1, 2018

@betatim I've added the basic functionality, but the bounding boxes do not show up for some reason. The demo.ipynb is probably the best starting point for experimenting

…s a box (still does not work correctly), adding a block to the demo notebook to make adding rois interactively easier)
@kmader
Copy link
Collaborator Author

kmader commented Oct 2, 2018

@betatim now the bounding boxes show up, but it is still a bit finicky

"""A method for feeding data into the widget"""
self._tool_state_in = json.dumps(state)
self._tool_state_out = json.dumps(state)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the two tool states?

Copy link
Collaborator Author

@kmader kmader Oct 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this isn't a very elegant approach, but one is for setting the state (_in) from Python and one is for reading the state (_out) from Cornerstone. The state itself isn't a traitlet and the traitlet is only updated on a mouseup event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants