rename react lifecycle methods to prefix "UNSAFE_" #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- via `npx react-codemod rename-unsafe-lifecycles`
- using options: ./src, "JavaScript with Flow"
- fixes console warnings for react v16.9.0
- fixes react v17 compatibility
- note that this doesn't do address the underlying motive of the
warnings regarding unsafe component lifecycle methods
|
technically fixes #569 |
|
@nkbt awesome! i don't have merge permission though, can you merge this? yes, the eslint change was just to get the build to pass |
|
I've tested this PR and also check if built version works ok in one of my projects and everything seems to work well without React warnings. Merging in. |
|
Cannot publish until #577 |
theopak
deleted the
theopak/2019-11-08-rename-unsafe-lifecycle-methods
branch
|
Hi @nkbt, will you make a release with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @chenglou and @nkbt! what do you think of potentially shipping this quick rename? it comes from
$ npx react-codemod rename-unsafe-lifecyclesand would make the developer experience a little better for consumers that are on react v16.9, like we are at @Frameiofor anyone just catching up with this situation — please note that this rename fixes the console warnings introduced in react@16.9 such that code will run in react@17, but this rename doesn't address the underlying issue
edit: i pushed a config change just to get the build to pass, so please lmk if there's a different way that would work better here