wip: add getAtomQueryFeaturesObject #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpatiny
commented
May 13, 2024
src/com/actelion/research/gwt/minimal/MoleculeQueryFeatures.java
Outdated
Show resolved
Hide resolved
|
It depends what you want to return. If you want a plain JS object, you should not create a new Java class. |
targos
reviewed
May 27, 2024
| PlainJSObject moleculeQueryFeatures = PlainJSObject.create(); | ||
|
|
||
| moleculeQueryFeatures.setPropertyBoolean("aromatic", | ||
| (oclMolecule.getAtomQueryFeatures(atom) & Molecule.cAtomQFAromatic) > 0); |
There was a problem hiding this comment.
Wouldn't it be significantly faster to call getAtomQueryFeatures(atom) only once and put the value in a local variable?
There was a problem hiding this comment.
Indeed good idea! The method getAtomQueryFeatures is super small so probably small impact but the code will look any much better and we will have the possibility to optimise the part that is 'int' and not long. Thanks.
public long getAtomQueryFeatures(int atom) {
return mAtomQueryFeatures[atom];
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.