Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve zone assignment label addition and editing functionality #3034

Merged
merged 4 commits into from
May 3, 2024

Conversation

hamed-musallam
Copy link
Member

No description provided.

@hamed-musallam hamed-musallam linked an issue May 2, 2024 that may be closed by this pull request
Copy link

cloudflare-pages bot commented May 2, 2024

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: aad74f7
Status: ✅  Deploy successful!
Preview URL: https://368157f9.nmrium.pages.dev
Branch Preview URL: https://improve-zone-assignment-labe.nmrium.pages.dev

View logs

@hamed-musallam hamed-musallam force-pushed the improve-zone-assignment-label branch from b842b9b to 6740f06 Compare May 2, 2024 13:20
@hamed-musallam hamed-musallam force-pushed the improve-zone-assignment-label branch from 6740f06 to 2d99990 Compare May 2, 2024 13:20
@lpatiny
Copy link
Member

lpatiny commented May 3, 2024

Could you change the highlight behaviour for the text ? Currently when highlighted it is less visible. I would suggest to simply but the text in bold and not change the color (or use dark red as color).

image

@hamed-musallam hamed-musallam merged commit d626f5e into main May 3, 2024
11 checks passed
@hamed-musallam hamed-musallam deleted the improve-zone-assignment-label branch May 3, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve zone assignment label
2 participants