Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xy data with discontinuous x #2825

Closed
wants to merge 4 commits into from

Conversation

andcastillo
Copy link

Solve the issue by getting the zones at before calling xyReduce.

Screenshot 2024-01-12 at 6 14 21 pm

Related to #2820

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (12d03b8) 2.19% compared to head (000d393) 2.31%.
Report is 10 commits behind head on main.

Files Patch % Lines
src/component/hooks/useXYReduce.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #2825      +/-   ##
========================================
+ Coverage   2.19%   2.31%   +0.12%     
========================================
  Files        639     643       +4     
  Lines      62469   63059     +590     
  Branches     690     701      +11     
========================================
+ Hits        1369    1461      +92     
- Misses     60512   61008     +496     
- Partials     588     590       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpatiny
Copy link
Member

lpatiny commented Jan 18, 2024

After discussion we will check if the x values are ok in nmr-load-save and will currently not deal with non continuous X because other algorithms would crash or give unexpected results.

@lpatiny lpatiny closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants