fix:Select component onChange event not firing on firefox

close #991
cheminfo · Apr 26, 2021 · f05e6d2 · f05e6d2
1 parent 4ac73a3
commit f05e6d2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/component/panels/RangesPanel/TableColumns/ActionsColumn.jsx b/src/component/panels/RangesPanel/TableColumns/ActionsColumn.jsx
@@ -6,7 +6,7 @@ import { FaRegTrashAlt, FaSearchPlus, FaEdit } from 'react-icons/fa';
 import { SignalKinds } from '../../../../data/constants/SignalsKinds';
 import { useAssignmentData } from '../../../assignment';
 import { useDispatch } from '../../../context/DispatchContext';
-import SelectUncontrolled from '../../../elements/SelectUncontrolled';
+import Select from '../../../elements/Select';
 import {
   useModal,
   positions,
@@ -123,10 +123,10 @@ function ActionsColumn({ rowData, onHoverSignal, rowSpanTags }) {
   return (
     <Fragment>
       <td {...onHoverSignal}>
-        <SelectUncontrolled
+        <Select
           onChange={changeRangeSignalKindHandler}
           data={SignalKinds}
-          value={rowData.tableMetaInfo.signal.kind}
+          defaultValue={rowData.tableMetaInfo.signal.kind}
           style={selectBoxStyle}
         />
       </td>

diff --git a/src/component/panels/ZonesPanel/TableColumns/ActionsColumn.jsx b/src/component/panels/ZonesPanel/TableColumns/ActionsColumn.jsx
@@ -4,7 +4,7 @@ import { FaRegTrashAlt, FaSearchPlus } from 'react-icons/fa';
 import { SignalKinds } from '../../../../data/constants/SignalsKinds';
 import { useAssignmentData } from '../../../assignment';
 import { useDispatch } from '../../../context/DispatchContext';
-import SelectUncontrolled from '../../../elements/SelectUncontrolled';
+import Select from '../../../elements/Select';
 import {
   CHANGE_ZONE_SIGNAL_KIND,
   DELETE_2D_ZONE,
@@ -68,12 +68,12 @@ function ActionsColumn({ rowData, rowSpanTags }) {
   return (
     <Fragment>
       <td>
-        <SelectUncontrolled
+        <Select
           onChange={(value) => {
             changeSignalKindHandler(value);
           }}
           data={SignalKinds}
-          value={rowData.tableMetaInfo.signal.kind}
+          defaultValue={rowData.tableMetaInfo.signal.kind}
           style={selectBoxStyle}
         />
       </td>