fix: prevent crash if range picking without finding peaks

cheminfo · Jan 28, 2022 · e472eaa · e472eaa
1 parent 9de01dc
commit e472eaa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/data/data1d/Spectrum1D/ranges/addRange.ts b/src/data/data1d/Spectrum1D/ranges/addRange.ts
@@ -19,15 +19,16 @@ export function addRange(datum: Datum1D, options: AddRangeOptions & SumParams) {
   const { x, re } = datum.data;
   const absolute = xyIntegration({ x, y: re }, { from, to, reverse: true });
 
-  const signals = detectSignal(x, re, from, to, datum.info.originFrequency);
-
+  // detectSignal use the advance multiplet-analysis that can crash if too many points
+  const signal = detectSignal(x, re, from, to, datum.info.originFrequency);
+  if (!signal) return;
   try {
     const range = {
       id: generateID(),
       from,
       to,
       absolute, // the real value,
-      signals: [{ id: generateID(), ...signals }],
+      signals: [{ id: generateID(), ...signal }],
       kind: DatumKind.signal,
       integration: 0,
     };

diff --git a/src/data/data1d/Spectrum1D/ranges/detectSignal.ts b/src/data/data1d/Spectrum1D/ranges/detectSignal.ts
@@ -16,7 +16,7 @@ export default function detectSignal(x, re, from, to, frequency) {
     takeBestPartMultiplet: true,
     symmetrizeEachStep: true,
   });
-
+  if (result && result.chemShift === undefined) return;
   return {
     multiplicity: result.js.map((j) => j.multiplicity).join(''),
     kind: 'signal',