fix: change enum to be a simple string (#1422)

cheminfo · Mar 11, 2022 · 38066dc · 38066dc
1 parent 08ada51
commit 38066dc
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 13 deletions.
diff --git a/src/component/NMRium.tsx b/src/component/NMRium.tsx
@@ -128,16 +128,12 @@ const containerStyles = css`
   }
 `;
 
-export enum NMRiumWorkspaces {
-  EXERCISE_1D = 'exercise1D',
-  PROCESS_1D = 'process1D',
-  DEFAULT = 'default',
-}
+export type NMRIumWorkspace = 'exercise1D' | 'process1D' | 'default';
 
 export interface NMRiumProps {
   data?: NMRiumData;
   onDataChange?: (data: State) => void;
-  workspace?: NMRiumWorkspaces;
+  workspace?: NMRIumWorkspace;
   preferences?: NMRiumPreferences;
   emptyText?: ReactNode;
   /**
@@ -219,7 +215,7 @@ function NMRium(props: NMRiumProps) {
 
 function InnerNMRium({
   data: dataProp = defaultData,
-  workspace = NMRiumWorkspaces.DEFAULT,
+  workspace = 'default',
   preferences = defaultPreferences,
   getSpinner = defaultGetSpinner,
   onDataChange,

diff --git a/src/component/reducer/preferencesReducer.ts b/src/component/reducer/preferencesReducer.ts
@@ -1,7 +1,6 @@
 import { Draft, produce } from 'immer';
 import lodashMerge from 'lodash/merge';
 
-import { NMRiumWorkspaces } from '../NMRium';
 import {
   getLocalStorage,
   removeData,
@@ -18,9 +17,9 @@ const LOCAL_STORAGE_VERSION = 3;
 
 function getPreferencesByWorkspace(workspace: string) {
   switch (workspace) {
-    case NMRiumWorkspaces.EXERCISE_1D:
+    case 'exercise1D':
       return workspaces.exercise1D;
-    case NMRiumWorkspaces.PROCESS_1D:
+    case 'process1D':
       return workspaces.process1D;
     default:
       return workspaces.basic;
@@ -148,7 +147,7 @@ function handleInit(draft: Draft<PreferencesState>, action) {
     }
     draft.display = lodashMerge(
       {},
-      getPreferencesByWorkspace(NMRiumWorkspaces.DEFAULT).display,
+      getPreferencesByWorkspace('default').display,
       hiddenModeFeatures,
       hiddenLocalStorageFeatures,
     );

diff --git a/src/demo/views/Exercise.tsx b/src/demo/views/Exercise.tsx
@@ -5,7 +5,7 @@ import { useState, useEffect, useCallback } from 'react';
 import { MF } from 'react-mf';
 import { StructureEditor } from 'react-ocl/full';
 
-import NMRium, { NMRiumWorkspaces } from '../../component/NMRium';
+import NMRium from '../../component/NMRium';
 
 let answers = JSON.parse(localStorage.getItem('nmrium-exercises') || '{}');
 
@@ -171,7 +171,7 @@ export default function Exercise(props) {
         >
           <NMRium
             data={data}
-            workspace={NMRiumWorkspaces.EXERCISE_1D}
+            workspace="exercise1D"
             preferences={{
               general: {
                 disableMultipletAnalysis: true,