fix: refactor nH parameter to integrationSum close #1318 (#1319)

cheminfo · Dec 18, 2021 · 1138d1d · 1138d1d
1 parent 5fe8092
commit 1138d1d
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/component/1d/Chart1D.tsx b/src/component/1d/Chart1D.tsx
@@ -5,9 +5,9 @@ import LinesSeries from './LinesSeries';
 import PeakAnnotations from './PeakAnnotations';
 import ResurrectedDatabaseRanges from './ResurrectedDatabaseRanges';
 import XAxis from './XAxis';
+import JGraph from './jCouplingGraph/JGraph';
 import MultiAnalysisRanges from './multiAnalysis/MultiAnalysisRanges';
 import Ranges from './ranges/Ranges';
-import JGraph from './jCouplingGraph/JGraph';
 
 function Chart1D({ mode, width, height, margin, displayerKey }) {
   return (

diff --git a/src/component/reducer/actions/RangesActions.ts b/src/component/reducer/actions/RangesActions.ts
@@ -47,7 +47,7 @@ function handleAutoRangesDetection(draft: Draft<State>, options) {
 
     const detectionOptions = {
       factorStd: 8,
-      nH: 100,
+      integrationSum: 100,
       compile: true,
       frequencyCluster: 16,
       clean: true,
@@ -70,7 +70,7 @@ function handleAutoSpectraRangesDetection(draft: Draft<State>) {
   const peakPicking = {
     factorStd: 8,
     minMaxRatio: 0.05,
-    nH: 100,
+    integrationSum: 100,
     compile: true,
     frequencyCluster: 16,
     clean: true,

diff --git a/src/data/data1d/Spectrum1D/ranges/autoRangesDetection.ts b/src/data/data1d/Spectrum1D/ranges/autoRangesDetection.ts
@@ -7,7 +7,7 @@ const defaultPeakPickingOptions = {
   realTopDetection: true,
   maxCriteria: true,
   smoothY: false,
-  nH: 100,
+  integrationSum: 100,
   factorStd: 5,
   clean: true,
   sgOptions: { windowSize: 7, polynomial: 3 },

diff --git a/src/data/data1d/Spectrum1D/ranges/detectRanges.ts b/src/data/data1d/Spectrum1D/ranges/detectRanges.ts
@@ -11,7 +11,7 @@ interface DetectRangesOptions {
   peakPicking: {
     factorStd: number; // default 8
     minMaxRatio: number; // default 0.1
-    nH: number; // default 100
+    integrationSum: number; // default 100
     compile: boolean; //default true
     frequencyCluster: number; // default 16
     clean: boolean; // default true

diff --git a/src/data/migration/migrateToVersion2.ts b/src/data/migration/migrateToVersion2.ts
@@ -98,7 +98,7 @@ function mapZones(zones) {
             deltaY,
             resolutionY,
             nucleusY,
-            // eslint-disable-next-line @typescript-eslint/no-unused-vars
+
             shiftX,
             shiftY,
             ...resSignal