Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] - Making Library TypeSafe - Refactoring #26

Merged
merged 9 commits into from
Aug 8, 2023

Conversation

adithyaakrishna
Copy link
Contributor

@adithyaakrishna adithyaakrishna commented Aug 2, 2023

Description:

  • We use this library at https://github.com/3dmol/3Dmol.js
  • I'm in the process of making that library TypeSafe, the netcdfjs module was not typesafe and hence I thought to send a fix to the upstream module as well :)

Edit: This PR is an extension of #24

Note: This PR is still a WIP

Adithya Krishna added 9 commits August 2, 2023 18:42
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
Signed-off-by: Adithya Krishna <adikrish@redhat.com>
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 95.58% and project coverage change: +1.30% 🎉

Comparison is base (bea14eb) 94.44% compared to head (27b083f) 95.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   94.44%   95.74%   +1.30%     
==========================================
  Files           6        6              
  Lines         252      282      +30     
  Branches       55       65      +10     
==========================================
+ Hits          238      270      +32     
+ Misses         14       12       -2     
Files Changed Coverage Δ
src/types.ts 94.73% <90.90%> (ø)
src/data.ts 91.66% <91.66%> (ø)
src/header.ts 95.69% <95.69%> (ø)
src/parser.ts 96.55% <100.00%> (ø)
src/toString.ts 100.00% <100.00%> (ø)
src/utils.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adithyaakrishna
Copy link
Contributor Author

@lpatiny Could you please let me know if there is any further testing or updating I need to do before confirming the changes?

@adithyaakrishna adithyaakrishna marked this pull request as ready for review August 2, 2023 18:08
@targos targos merged commit 9bf14de into cheminfo:master Aug 8, 2023
9 checks passed
@targos
Copy link
Member

targos commented Aug 8, 2023

Thanks a lot!

This was referenced Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants