sk-tcp: Improve TCP socket options handling

[juntongdeng]

This pull request improves the dumping and restoring of TCP socket options in CRIU.

Currently some of the TCP socket option information is stored in the TcpStreamEntry, but the information in the TcpStreamEntry is only restored after the TCP socket has established connection, which results in these TCP socket options not being restored for unconnected TCP sockets.

Move the TCP socket options from TcpStreamEntry to TcpOptsEntry and add dump_tcp_opts() and restore_tcp_opts() for TCP socket options dump and restore.

Currently some TCP socket option information is stored in SkOptsEntry, which is a little confusing. SkOptsEntry should only contain socket options that are common to all sockets.

Move the TCP-specific socket options from SkOptsEntry to TcpOptsEntry.

Currently there are no socket option test cases for TCP_CORK and TCP_NODELAY, this commit adds related test cases.

The socket option test cases for TCP_KEEPCNT, TCP_KEEPIDLE, and TCP_KEEPINTVL already exist in socket-tcp_keepalive.c, so they are not included in this pull request.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 70.58%. Comparing base (00d7cdc) to head (9076b33).

❗ Current head 9076b33 differs from pull request most recent head 859800b. Consider uploading reports for the commit 859800b to get more accurate results

Files	Patch %	Lines
criu/sk-inet.c	72.72%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           criu-dev    #2380      +/-   ##
============================================
- Coverage     70.73%   70.58%   -0.15%     
============================================
  Files           136      135       -1     
  Lines         32940    33462     +522     
============================================
+ Hits          23299    23620     +321     
- Misses         9641     9842     +201     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[juntongdeng]

I see that code linter fails, but I don't seem to find the EOL whitespace problem in sk-inet.c?

[juntongdeng]

It seems that the CRIU Image Streamer Test is stuck in the zdtm/transition/socket_loop00 test case.

But the zdtm/transition/socket_loop00 test case can end normally and pass on my computer.

[adrianreber]

Don't worry. The image streamer tests are known to timeout sometimes.

[rst0git]

We continue to support restoring TCP socket options from TcpStreamEntry and SkOptsEntry, but dumping TCP socket options to TcpOptsEntry in new versions of CRIU.

@juntongdeng Could you please add a comment in the code before restoring TcpStreamEntry and SkOptsEntry that this is done for backward comparability, and newer versions of CRIU use TcpOptsEntry?

[juntongdeng]

@juntongdeng Could you please add a comment in the code before restoring TcpStreamEntry and SkOptsEntry that this is done for backward comparability, and newer versions of CRIU use TcpOptsEntry?

Yes, will do

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[juntongdeng]

We continue to support restoring TCP socket options from TcpStreamEntry and SkOptsEntry, but dumping TCP socket options to TcpOptsEntry in new versions of CRIU.

@juntongdeng Could you please add a comment in the code before restoring TcpStreamEntry and SkOptsEntry that this is done for backward comparability, and newer versions of CRIU use TcpOptsEntry?

fixed

[juntongdeng]

How to remove "stale-pr" label?

[Snorch]

Looks good.

Test fails seem to be unrelated:

1. Cirrus CI / Vagrant Fedora Rawhide based test
   https://github.com/checkpoint-restore/criu/pull/2380/checks?check_run_id=25148861695
   Error is setenforce: SELinux is disabled, seems like we just have selinux disabled in kernel in this env. Does not seem to be related socket opritons or this PR.

2. Cross Compile Tests / build (true, mips64el-unstable-cross)
   https://github.com/checkpoint-restore/criu/actions/runs/9147441768/job/25160880160?pr=2380
   Error is ERROR: failed to solve: process "/bin/sh -c apt-install ..., seems like a package install problem. Does not seem to be related to this PR.

3. Compat Tests / build (GCC)
   https://github.com/checkpoint-restore/criu/actions/runs/9147441773/job/25160879538?pr=2380
   Error is FAIL: vdso01.c:434: Failed to call vdso handlers from symtable after C/R (errno = 11 (Resource temporarily unavailable)), I see same error in other PR CI. (ERR: vdso01.c:378: Delta is too big #2390)

[rst0git]

LGTM

[avagin]

Merged. Thanks a lot.