ztdm: inhfd: handle child hanging #2251
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So it seems some tests didn't expect timeouts to work... |
osctobe
force-pushed
the
zdtm-alarm-handling
branch
4 times, most recently
from
4b6cb00
to
a4b820d
Compare
osctobe
force-pushed
the
zdtm-alarm-handling
branch
from
a4b820d
to
68c7b0c
Compare
osctobe
force-pushed
the
zdtm-alarm-handling
branch
from
68c7b0c
to
3e580c8
Compare
osctobe
force-pushed
the
zdtm-alarm-handling
branch
from
3e580c8
to
b883c49
Compare
osctobe
force-pushed
the
zdtm-alarm-handling
branch
from
b883c49
to
65d9823
Compare
Let's kill the child when the test is hanging. Due to PEP 475 the SIGALRM handler needs to throw an exception to be able to interrupt wait(). To improve debuggig, close the fd in the child after reading it and detect that in the parent to show whether the child hung part way. Signed-off-by: Michał Mirosław <emmir@google.com>
osctobe
force-pushed
the
zdtm-alarm-handling
branch
from
65d9823
to
974f9cc
Compare
rst0git
added
no-auto-close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's kill the child when the test is hanging. Due to PEP 475 the SIGALRM handler needs to throw an exception to be able to interrupt wait(). To improve debuggig, close the fd in the child after reading it and detect that in the parent to show whether the child hung part way.