Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove permadiff on ssl_check_domain #286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove permadiff on ssl_check_domain #286

wants to merge 1 commit into from
+1 −1

Conversation

0x416e746f6e
Copy link

Affected Components

  • Resources
  • Test
  • Docs
  • Tooling
  • Other

Pre-Requisites

  • Terraform code is formatted with terraform fmt
  • Go code is formatted with go fmt
  • plan & apply command of demo/main.tf file do not produce diffs

Notes for the Reviewer

Resolves #282

@Antoine-C
Copy link
Contributor

Hello @0x416e746f6e 👋

Thanks for the PR, I will take a look at it / merge it next week 🤞

@0x416e746f6e
Copy link
Author

Hello @0x416e746f6e 👋

Thanks for the PR, I will take a look at it / merge it next week 🤞

hi @Antoine-C! how is it going?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxigimenez maxigimenez Awaiting requested review from maxigimenez maxigimenez is a code owner

@pilimartinez pilimartinez Awaiting requested review from pilimartinez pilimartinez is a code owner

@Antoine-C Antoine-C Awaiting requested review from Antoine-C Antoine-C is a code owner

@shiini2 shiini2 Awaiting requested review from shiini2 shiini2 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: checkly_check permadiff on ssl_check_domain attribute
2 participants
@0x416e746f6e @Antoine-C