Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check examples to the ms docs #1016

Merged
merged 3 commits into from May 13, 2024
Merged

add check examples to the ms docs #1016

merged 3 commits into from May 13, 2024

Conversation

drakirnosslin
Copy link
Collaborator

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

Notes for the Reviewer

New Dependency Submission

Screenshots

@drakirnosslin drakirnosslin requested a review from tnolet as a code owner May 8, 2024 12:34
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 2:48pm

Copy link
Contributor

@ragog ragog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drakirnosslin left some nits and suggestions.

site/content/docs/multistep-checks/example-checks.md Outdated Show resolved Hide resolved
```

### Verifying binary payloads
One way to ensure that e.g CDN endpoints are serving images correctly is by verifying its binary.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drakirnosslin nit: missing dot after the g, e.g.

})
```

If you have suggestions for additional check examples to add here, please do not hesitate to reach out to our [support](mailto:support@checklyhq.com), or join our [Slack community](https://www.checklyhq.com/slack/).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drakirnosslin suggestion: we could also ask people to submit a PR, since the repo is public.

Copy link
Contributor

@ragog ragog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drakirnosslin drakirnosslin merged commit dbea6ce into main May 13, 2024
6 checks passed
@drakirnosslin drakirnosslin deleted the add-ms-code-examples branch May 13, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants