New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: copilot chat extension does not work #335
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
99cf176
fix: avoid using `silent` when getting a session
vitaliy-guliy fccb597
fix: extension should get a session
vitaliy-guliy e5571b9
fix: extension should get a session
vitaliy-guliy c594221
fix: extension should get a session
vitaliy-guliy cfd91f9
fix: add rebase rule
vitaliy-guliy 4884edd
Merge branch 'main' into copilot-chat
vitaliy-guliy c8ff33d
fix: add changes to CHANGELOG.md
vitaliy-guliy 741b96a
Merge branch 'main' into copilot-chat
vitaliy-guliy 12304a0
Merge branch 'main' into copilot-chat
vitaliy-guliy File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
.rebase/replace/code/src/vs/workbench/api/browser/mainThreadAuthentication.ts.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
[ | ||
{ | ||
"from": "// We may need to prompt because we don't have a valid session", | ||
"by": "// We may need to prompt because we don't have a valid session\\\n\\\t\\\tif (options.silent) {\\\n\\\t\\\t\\\toptions.silent = false;\\\n\\\t\\\t\\\toptions.createIfNone = true;\\\n\\\t\\\t}\\\n" | ||
} | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vitaliy-guliy
I tested this solution - it works for me - I'm able to use Github Copilot Chat extension,
thank you!
At the same time it's still unclear how it works on VS Code side without these changes.
Also I detected some side-effects of the current solution:
sign in using GitHub
directly after starting a workspacesign in using GitHub
only when I'm using some command that requires it (git clone for example)Another use case is -
Sign Out
:Sign In
directly afterSign Out
for all extensions, like: I doSign Out
=> 3 dialogs are shown toSign in
for 3 extensionsWithout these changes:
https://github.com/che-incubator/che-code/assets/5676062/87a7f967-6621-4e26-b52d-04fb0e1e4cb3
With these changes:
https://github.com/che-incubator/che-code/assets/5676062/702d9f6b-29f4-4cf4-9c57-e069f5fe3a13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's OK for me to merge the PR as is if we don't have another solution that allows to avoid those side-effects - they are insignificant from my point of view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, user is asked to grant the access when the extension wants to get a session.
But is seems user is asked only once at the workspace startup.
It should not be very annoying in case you want to use extension like copilot.
From the other side, clicking the button each time when creating a workspace could make a user a bit nervous.
I created another PR to test a bit different behavior #339
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also described another use case above:
I want to
Sign Out
=> 3 dialogs are shown toSign in
for 3 extensionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure users are practicing signing out in a real life.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But yes, it's a case