feat: Revamp basic profile, avatar and message signature #9310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
muhsin-k
commented
Apr 27, 2024
muhsin-k
commented
| Light mode | Dark mode |
|---|---|
 |
 |
muhsin-k
changed the title
muhsin-k
changed the title
scmmishra
requested changes
Apr 29, 2024
app/javascript/dashboard/routes/dashboard/settings/personal/BasePersonalItem.vue
Outdated
Show resolved
Hide resolved
app/javascript/dashboard/routes/dashboard/settings/personal/BasePersonalItem.vue
Outdated
Show resolved
Hide resolved
app/javascript/dashboard/routes/dashboard/settings/personal/Index.vue
Outdated
Show resolved
Hide resolved
app/javascript/dashboard/routes/dashboard/settings/personal/Index.vue
Outdated
Show resolved
Hide resolved
app/javascript/dashboard/routes/dashboard/settings/personal/Index.vue
Outdated
Show resolved
Hide resolved
app/javascript/dashboard/routes/dashboard/settings/personal/MessageSignature.vue
Outdated
Show resolved
Hide resolved
app/javascript/dashboard/routes/dashboard/settings/personal/MessageSignature.vue
Outdated
Show resolved
Hide resolved
app/javascript/dashboard/routes/dashboard/settings/personal/UserBasicDetails.vue
Show resolved
Hide resolved
app/javascript/dashboard/routes/dashboard/settings/personal/UserBasicDetails.vue
Outdated
Show resolved
Hide resolved
app/javascript/dashboard/routes/dashboard/settings/personal/UserProfilePicture.vue
Outdated
Show resolved
Hide resolved
@scmmishra This just a temporary page for testing. Once I merge all the components for profile section. I will rename this route and delete the old profile page. |
iamsivin
reviewed
Apr 29, 2024
app/javascript/dashboard/routes/dashboard/settings/personal/MessageSignature.vue
Outdated
Show resolved
Hide resolved
app/javascript/dashboard/routes/dashboard/settings/personal/personal.routes.js
Outdated
Show resolved
Hide resolved
…ssageSignature.vue Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com>
…rsonal.routes.js Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com>
scmmishra
reviewed
Apr 29, 2024
profileUpdate in auth.js handles `displayName` specifically, so adding the property separately as `display_name` caused the value to be overriden as empty
scmmishra
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Let's rewrite this in the setup syntax once the composables are merged. Approving it for now
scmmishra
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.