feat: add composables for migration and update portal settings #9299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scmmishra
force-pushed
the
feat/refactor-hc-composition
branch
from
60a35b4
to
3aa281f
Compare
muhsin-k
reviewed
Apr 29, 2024
app/javascript/dashboard/routes/dashboard/helpcenter/pages/portals/PortalCustomization.vue
Show resolved
Hide resolved
muhsin-k
reviewed
Apr 29, 2024
app/javascript/dashboard/routes/dashboard/helpcenter/pages/portals/PortalCustomization.vue
Outdated
Show resolved
Hide resolved
muhsin-k
reviewed
Apr 29, 2024
...ascript/dashboard/routes/dashboard/helpcenter/components/PortalSettingsCustomizationForm.vue
Show resolved
Hide resolved
muhsin-k
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates portal settings to use the new composition API along with the
<script setup>syntax. This PR is supposed to be a reference on how to migrate existing views to Vue 3 compatible syntax without breaking any functionalityCore changes
storerouteshowAlert$trackPortal Changes
5xlfor tables and2xlfor forms<script setup>syntax wherever possibleMoveCan do in a separate PRportalMixinto a composable (Not sure if this is possible :P)