feat: include resolution time and waiting time in team & agent report #9296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scmmishra
force-pushed
the
feat/update-reports-CW-3204
branch
from
2624cf4
to
e5e20f1
Compare
scmmishra
force-pushed
the
feat/update-reports-CW-3204
branch
from
e5e20f1
to
3045773
Compare
scmmishra
changed the title
|
@sojan-official need your review on this. A thing to note is that this might reverse the perf benefits we got in #8733 |
pranavrajs
reviewed
Apr 26, 2024
app/builders/v2/report_builder.rb
Outdated
Comment on lines
53
to
55
| avg_resolution_time: avg_resolution_time_summary, | ||
| resolutions_count: resolutions.count, | ||
| reply_time: reply_time_summary |
There was a problem hiding this comment.
@scmmishra Can we run the query only on the download? These would add additional query and would fail already overloaded API.
There was a problem hiding this comment.
The report for download is made using the generate_report function in report_helpers which uses the short_summary method internally. All these params are required to generate the new downloads.
One thing I can do is use the summary method for agent and teams report and rest of the reports can use the short summary. You can see the changes in this commit 134e886
Is this what you were looking for?
pranavrajs
requested changes
Apr 26, 2024
pranavrajs
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.