Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: active card class not applied correctly #9292

Closed
wants to merge 1 commit into from

Conversation

s00d
Copy link
Contributor

@s00d s00d commented Apr 24, 2024

Description

You use this here:

'div.conversations-list div.conversation.active'

'div.conversations-list div.conversation.active'

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

scmmishra
scmmishra previously approved these changes Apr 24, 2024
@scmmishra scmmishra changed the title fix: active cart fix: active card class not applied correctly Apr 24, 2024
@scmmishra scmmishra changed the base branch from master to develop April 29, 2024 11:06
@scmmishra scmmishra changed the base branch from develop to master April 29, 2024 11:07
@scmmishra scmmishra dismissed their stale review April 29, 2024 11:08

made on the wrong branch

@scmmishra
Copy link
Member

Hey @s00d seems like this change is already present on the develop branch. At the moment, no changes are being accepted on the master branch. I'll close this PR for now

@scmmishra scmmishra closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants