Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support document file uploads on telegram channel #9266

Merged
merged 9 commits into from May 2, 2024

Conversation

sojan-official
Copy link
Member

@sojan-official sojan-official commented Apr 19, 2024

The previous implementation of file uploads in telegram channel only supported media group attachments. This cause breakages when attachments are mixed mode or contains document file types like txt, .avi etc. This PR fixes that.

Test cases

  • single attachments -> photo, video, audio , txt , pdf
  • grouped attachments -> photo, video, audio, photo+video, txt
  • mixed group attachments -> photo (2) + video + audio (2) + txt
  • Ensure success status in all these cases

@vishnu-narayanan vishnu-narayanan temporarily deployed to chatwoot-pr-9266 April 19, 2024 23:45 Inactive
@pranavrajs
Copy link
Member

Tested multiple cases, seems to be working.

@pranavrajs pranavrajs merged commit ac93af6 into develop May 2, 2024
15 of 16 checks passed
@pranavrajs pranavrajs deleted the chore/telegram-attachment-fix branch May 2, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants