Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom date picker #9247

Merged
merged 43 commits into from Apr 29, 2024
Merged

feat: Custom date picker #9247

merged 43 commits into from Apr 29, 2024

Conversation

iamsivin
Copy link
Member

@iamsivin iamsivin commented Apr 16, 2024

Pull Request Template

Description

This PR includes a custom calendar date picker.

Fixes https://linear.app/chatwoot/issue/CW-3189/date-picker

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Loom video
https://www.loom.com/share/41b3a56c4e324efbb66d5e39015d9303?sid=b6348375-cf40-4469-ab70-65debbcae565

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@iamsivin iamsivin changed the title Feat/custom date picker feat: Custom date picker Apr 16, 2024
@iamsivin iamsivin marked this pull request as ready for review April 17, 2024 16:46
Copy link

linear bot commented Apr 17, 2024

CW-3189 Date Picker

@iamsivin iamsivin requested a review from scmmishra April 23, 2024 09:01
Copy link
Member

@scmmishra scmmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some design and UX related feedback

Clicking inactive dates

Here I am able to select a date even if the button state is disabled, we should probably not allow that, it may lead to confusion. Perhaps we can hide those dates completely and not show anything at all.

CleanShot.2024-04-24.at.12.55.13.mp4

Navigating months

I have described the issue in this video (🔈 Sound On)

CleanShot.2024-04-24.at.13.00.50.mp4

@absurdiya We will need your help figuring out the best UX for this.

@iamsivin we can do this in a follow-up PR too

Copy link
Member

@muhsin-k muhsin-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it locally and everything is working as expected.

@iamsivin iamsivin assigned pranavrajs and unassigned scmmishra Apr 24, 2024
@iamsivin iamsivin merged commit 2872863 into develop Apr 29, 2024
14 of 15 checks passed
@iamsivin iamsivin deleted the feat/custom-date-picker branch April 29, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants