feat: Script to migrate images between providers #9117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiagodotme
reviewed
Mar 27, 2024
lib/active_storage/migrator.rb
Outdated
|
|
||
| puts "#{ActiveStorage::Blob.count} Blobs to migrate from #{from_service_name} to #{to_service_name}" | ||
| ActiveStorage::Blob.find_each do |blob| | ||
| next unless blob.image? |
There was a problem hiding this comment.
This line prevents uploading of audio files received via WhatsApp. It will possibly impact PDF's and other files in general.
There was a problem hiding this comment.
Hi @hiagodotme, of course, I assumed they wanted to export only images because the issue specifically mentioned images, but we can add other types of files without a problem. 👍🏼
|
🐢 Turtley slow progress alert! This pull request has been idle for over 30 days. Can we please speed things up and either merge it or release it back into the wild? |
|
Hi @sojan-official, can I ask you for help with the checks that I am not being able to pass, if you can help me identify what the problem is why I am not being able to pass the checks??? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Storage migration functionality, which allows the transfer of images from one on-premises provider to another (e.g. AWS, Google, etc.) using Active Storage.
I ran the unit and integration tests and they all passed correctly.
The command to execute the migration is
FROM=from_service TO=to_service rake storage:migrateFixes #7907
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I have tested the storage migration functionality by running the provided unit and integration tests. Additionally, I manually tested the migration process in a local development environment by following these steps:
Set up two storage services (e.g., AWS S3 and Google Cloud Storage) with valid configurations.
Execute the
FROM=local TO=amazon rake storage:migratetask with appropriate FROM and TO arguments to migrate blobs between the services.Verified that the blobs were successfully transferred to the target storage service.
Checked for any error messages or unexpected behavior during the migration process.
Checklist: