Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building standalone package on macOS #315

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AnAnonymousUsername
Copy link

  • Adds ICNS format of existing Chatty ICO
  • Sets default javapackager native format to installer on macOS
  • Adds project property to override native format

You may want to consider changing the native format to installer on all platforms (msi on Windows, pkg on macOS, RPM/DEB on Linux), rather than image on Windows (exe), but I didn't want to change that unilaterally.

@tduva
Copy link
Contributor

tduva commented Apr 1, 2019

Are you wanting to build a macOS package yourself? I can't do it myself, since I'd have to be on Mac.

What benefit would changing the native format to installer have on Windows? Note that the currently created installer is used for updating Chatty on Windows and needs to be able to handle all that properly. Plus not everyone wants to use an installer, so building the image would still be necessary.

@AnAnonymousUsername
Copy link
Author

Yes, I've been building the package myself, but don't want to have to keep rebasing it every release before I build it.

Anonymous added 2 commits April 21, 2019 13:21
The `installer` native type builds both 3rd party `pkg` and another
intended for sending to the Mac App Store. That's generally not needed,
so just build the 3rd party `pkg` by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants